Delete wrong relationships in IUPAC mapping - #451
Open
kara-mela wants to merge 1 commit into
Open
Conversation
Motivation Several relationships in the mapping between IUPAC and PaNET were wrong and neet to be deleted. Modification The relationships were deleted. Result Improved correctness of the mapping.
RKrahl
reviewed
Sep 11, 2026
Member
There was a problem hiding this comment.
Ok, this is a tough one to review, because I'm lacking the physical understanding to judge whether the relations are wrong indeed. On the face of it, it seems that you are right, though. Therefore, at this point, only a few unsorted comments and suggestions:
- @kara-mela, you were the the only editor of the IUPAC mapping before this PR, so I trust that you know what you're doing when retracting some of the relations. That is why, in principle, I'd be happy to approve despite my lack of understanding in the details,
- I made a suggestion on the change in line 13, though. Reverting that change would fix the merge conflict,
- I'd suggest to merge the latest version of
masterinto your branch before the final review. As I understand.github/workflows/build.ymlthis would fix the failing build (because in the latest version onmaster, it would skip trying to deploy).
| # mapping_set_description: Manually curated alignment of the PaNET ontology with the IUPAC goldbook.,,,,,,,,, | ||
| # Intended to be used for ontological analysis.,,,,,,,,, | ||
| # mapping_set_id: mapping_goldbook_PaNET_v1.0,,,,,,,,, | ||
| # mapping_set_id: mapping_goldbook_PaNET_v2.0.0,,,,,,,,, |
Member
There was a problem hiding this comment.
Why are changing the PaNET version in mapping_set_id here? I can't see how this is related to the intention of your PR. This change is causing the merge conflict with the master branch. I'd rather suggest to leave that line alone, e.g. to revert the change in this line:
Suggested change
| # mapping_set_id: mapping_goldbook_PaNET_v2.0.0,,,,,,,,, | |
| # mapping_set_id: mapping_goldbook_PaNET_v1.0,,,,,,,,, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Several relationships in the mapping between IUPAC and PaNET were wrong and neet to be deleted.
Modification
The relationships were deleted.
Result
Improved correctness of the mapping.
Related Issues
Closes #422